Skip to content

remove a bunch of @js-expect-error and generally make rustdoc js more typechecked. #136372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove a bunch of @js-expect-error and generally make rustdoc js more typechecked. #136372

wants to merge 1 commit into from

Conversation

lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Feb 1, 2025 •
edited
Loading

@rustbot
Copy link
Collaborator

rustbot commented Feb 1, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 1, 2025
@lolbinarycat
Copy link
Contributor Author

r? @notriddle

@rustbot rustbot assigned notriddle and unassigned fmease Feb 1, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the rustdoc-js-settings-ts branch from 0cc843c to 6c82958 Compare February 1, 2025 04:07
@lolbinarycat
Copy link
Contributor Author

closing in favor of #136263

i guess i'll work on porting the less important scripts instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lolbinarycat @rustbot @rust-log-analyzer @notriddle @fmease