-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Don't remove mysql in CI #137041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't remove mysql in CI #137041
Conversation
can't we just stop trying to remove MySQL specifically? I know we want images with less stuff on them but it doesn't seem like it'd save us that much space. |
Maybe? But my motivation is to get CI moving again so I'd prefer not to risk it here. I leave that for someone else to investigate at their leisure. |
I certainly won't insist on my idea if this works out. |
We tried using disable before, and it was also causing similar issues. I think that the safer bet is just to avoid uninstalling MySQL. |
Ok, I can do that. Two votes to one, ha. |
kinda sucks that GH requires us to use images with so much bloatware but w/e |
Done. |
Will wait a minute if PR CI passes the free disk stage, and then I'll approve it. |
Looks like it went through. Hopefully this will fix the issue.. Thank you! @bors r+ p=101 |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fc147b4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 790.257s -> 791.712s (0.18%) |
After this PR, our ARM jobs suddenly got an hour longer: I don't think that the PR itself is the cause, rather it seems like GitHub changed something (which explains the sudden breakage of our CI), which might have also caused the ARM runners to become slower. I wonder if it was the rollback of the faulty ARM hardware (#135867). In any case, something to watch out for. CC @marcoieni, as you might be interested in this. |
I think this works around the issue?
r? @Kobzol