Skip to content

Don't remove mysql in CI #137041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Don't remove mysql in CI #137041

merged 1 commit into from
Feb 15, 2025

Conversation

ChrisDenton
Copy link
Member

I think this works around the issue?

r? @Kobzol

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 14, 2025
@workingjubilee
Copy link
Member

can't we just stop trying to remove MySQL specifically? I know we want images with less stuff on them but it doesn't seem like it'd save us that much space.

@ChrisDenton
Copy link
Member Author

Maybe? But my motivation is to get CI moving again so I'd prefer not to risk it here. I leave that for someone else to investigate at their leisure.

@workingjubilee
Copy link
Member

I certainly won't insist on my idea if this works out.

@Kobzol
Copy link
Contributor

Kobzol commented Feb 14, 2025

We tried using disable before, and it was also causing similar issues. I think that the safer bet is just to avoid uninstalling MySQL.

@ChrisDenton
Copy link
Member Author

Ok, I can do that. Two votes to one, ha.

@workingjubilee
Copy link
Member

workingjubilee commented Feb 14, 2025

kinda sucks that GH requires us to use images with so much bloatware but w/e

@ChrisDenton ChrisDenton changed the title Don't error if stopping mysql fails in CI Don't remove mysql in CI Feb 14, 2025
@ChrisDenton
Copy link
Member Author

Done.

@Kobzol
Copy link
Contributor

Kobzol commented Feb 14, 2025

Will wait a minute if PR CI passes the free disk stage, and then I'll approve it.

@Kobzol
Copy link
Contributor

Kobzol commented Feb 14, 2025

Looks like it went through. Hopefully this will fix the issue.. Thank you!

@bors r+ p=101

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

📌 Commit cb9cb1d has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 14, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2025
@bors
Copy link
Collaborator

bors commented Feb 14, 2025

⌛ Testing commit cb9cb1d with merge fc147b4...

@bors
Copy link
Collaborator

bors commented Feb 15, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing fc147b4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2025
@bors bors merged commit fc147b4 into rust-lang:master Feb 15, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 15, 2025
@ChrisDenton ChrisDenton deleted the mysql branch February 15, 2025 00:30
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fc147b4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 790.257s -> 791.712s (0.18%)
Artifact size: 347.74 MiB -> 347.74 MiB (0.00%)

@Kobzol
Copy link
Contributor

Kobzol commented Feb 17, 2025

After this PR, our ARM jobs suddenly got an hour longer:
image

I don't think that the PR itself is the cause, rather it seems like GitHub changed something (which explains the sudden breakage of our CI), which might have also caused the ARM runners to become slower. I wonder if it was the rollback of the faulty ARM hardware (#135867). In any case, something to watch out for.

CC @marcoieni, as you might be interested in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants