mk: Depend on regex_macros for tests appropriately #13845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently not much precedent for target crates requiring syntax extensions to compile their test versions. This dependency is possible, but can't be encoded through the normal means of DEPS_regex because it is a test-only dependency and it must be a *host* dependency (it's a syntax extension). Closes rust-lang#13844
bors
added a commit
that referenced
this pull request
Apr 29, 2014
There is currently not much precedent for target crates requiring syntax extensions to compile their test versions. This dependency is possible, but can't be encoded through the normal means of DEPS_regex because it is a test-only dependency and it must be a *host* dependency (it's a syntax extension). Closes #13844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently not much precedent for target crates requiring syntax
extensions to compile their test versions. This dependency is possible, but
can't be encoded through the normal means of DEPS_regex because it is a
test-only dependency and it must be a host dependency (it's a syntax
extension).
Closes #13844