Instantiate binder before registering nested obligations for auto/built-in traits #138915
Conversation
rustbot
added
S-waiting-on-review
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
Instantiate binder before registering nested obligations for auto/built-in traits Instead of turning a `Binder<Vec<Ty>>` into a bunch of `Binder<Predicate>`, instantiate the binder eagerly *once* and turn them into a bunch of non-higher ranked predicates. This `enter_forall_and_leak_universe` call would be where we could instantiate bound lifetime assumptions for coroutine witnesses... if we had them. r? lcnr
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
wouldnt hurt to run crater i guess @craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
Finished benchmarking commit (b2fb67b): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 10.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.151s -> 779.42s (0.29%) |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
All failures unrelated (including https://crater-reports.s3.amazonaws.com/pr-138915/try%23b2fb67b8b6007ced9ad3f3b752a6fec899e7859c/gh/WillPapper.zkvm-uuid-generation/log.txt which is a regular on crater failures. I think it's using GCE lol.) |
|
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2216f26 (parent) -> ea1da92 (this PR) Test differencesShow 32933 test diffsStage 1
Stage 2
(and 16362 additional test diffs) Additionally, 16471 doctest diffs were found. These are ignored, as they are noisy. Job group index
|
|
Finished benchmarking commit (ea1da92): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.4%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 778.377s -> 778.054s (-0.04%) |
Instead of turning a
Binder<Vec<Ty>>into a bunch of higher-ranked predicates, instantiate the binder eagerly once and turn them into a bunch of non-higher-ranked predicates.Right now this feels like a noop, but this
enter_forall_and_leak_universecall would be the singular place where we could instantiate bound lifetime assumptions for coroutine witnesses... if we had them. Thus consolidating the binder instantiation here is useful if we want to fix the coroutine-auto-trait problem.r? lcnr