Remove/Update dead links on Tasks guide. #13924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * [`sync::RWArc`] - A dual-mode Arc protected by a reader-writer lock, | ||
| * [`sync::MutexArc`] - An Arc with mutable data protected by a blocking mutex, | ||
| * [`sync::Semaphore`] - A counting, blocking, bounded-waiting semaphore, | ||
| * [`sync::raw::Semaphore`] - A counting, blocking, bounded-waiting semaphore, |
There was a problem hiding this comment.
This is actually still correct, and it's favored to use sync::Semaphore instead of sync::raw::Semaphore
There was a problem hiding this comment.
Interesting.The link is currently dead on master as it looks like sync::Semaphore is just a reexport. What's the appropriate place to link to? Should I just link to sync::raw::Semaphore and leave the name alone?
There was a problem hiding this comment.
I'd leave the name as sync::Semaphore and link to sync::raw::Semaphore.
|
Updated the link name. |
|
Looks good to me, thanks! Could you squash the commits together? |
|
Done. Thanks! |
bors
added a commit
that referenced
this pull request
May 5, 2014
Most of the links I've removed are for types that don't exist anymore with the exception of `SendReceiver` though I'm not sure how useful it is to link to that without the accompanying `Receiver` and `Sender` and I don't know how useful those links are when they're discussed below and `channel`/`sync_channel` is on the `std::comm` page already linked.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
internal: sync from downstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the links I've removed are for types that don't exist anymore with the exception of
SendReceiverthough I'm not sure how useful it is to link to that without the accompanyingReceiverandSenderand I don't know how useful those links are when they're discussed below andchannel/sync_channelis on thestd::commpage already linked.