Skip to content

Allow parenthesis around inferred array lengths #139641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion compiler/rustc_ast_lowering/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2034,7 +2034,9 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
}

fn lower_array_length_to_const_arg(&mut self, c: &AnonConst) -> &'hir hir::ConstArg<'hir> {
match c.value.kind {
// We cannot just match on `ExprKind::Underscore` as `(_)` is represented as
// `ExprKind::Paren(ExprKind::Underscore)` and should also be lowered to `GenericArg::Infer`
match c.value.peel_parens().kind {
ExprKind::Underscore => {
if !self.tcx.features().generic_arg_infer() {
feature_err(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
error[E0658]: const arguments cannot yet be inferred with `_`
--> $DIR/parend_infer.rs:24:16
|
LL | let c: Foo<_> = Foo::<1>;
| ^
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error[E0658]: const arguments cannot yet be inferred with `_`
--> $DIR/parend_infer.rs:26:16
|
LL | let c: Foo<(_)> = Foo::<1>;
| ^^^
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error[E0658]: const arguments cannot yet be inferred with `_`
--> $DIR/parend_infer.rs:28:16
|
LL | let c: Foo<(((_)))> = Foo::<1>;
| ^^^^^^^
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error[E0658]: using `_` for array lengths is unstable
--> $DIR/parend_infer.rs:17:17
|
LL | let b: [u8; (_)] = [1; (((((_)))))];
| ^^^
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error[E0658]: using `_` for array lengths is unstable
--> $DIR/parend_infer.rs:17:28
|
LL | let b: [u8; (_)] = [1; (((((_)))))];
| ^^^^^^^^^^^
|
= note: see issue #85077 <https://github.com/rust-lang/rust/issues/85077> for more information
= help: add `#![feature(generic_arg_infer)]` to the crate attributes to enable
= note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

error: aborting due to 5 previous errors

For more information about this error, try `rustc --explain E0658`.
20 changes: 19 additions & 1 deletion tests/ui/const-generics/generic_arg_infer/parend_infer.rs
Original file line number Diff line number Diff line change
@@ -1,12 +1,30 @@
//@ check-pass
//@[gate] check-pass
//@ revisions: gate nogate
#![cfg_attr(gate, feature(generic_arg_infer))]

struct Foo<const N: usize>;

fn main() {
// AST Types preserve parens for pretty printing reasons. This means
// that this is parsed as a `TyKind::Paren(TyKind::Infer)`. Generic
// arg lowering therefore needs to take into account not just `TyKind::Infer`
// but `TyKind::Infer` wrapped in arbitrarily many `TyKind::Paren`.
let a: Vec<(_)> = vec![1_u8];
let a: Vec<(((((_)))))> = vec![1_u8];

// AST Exprs similarly preserve parens for pretty printing reasons.
#[rustfmt::skip]
let b: [u8; (_)] = [1; (((((_)))))];
//[nogate]~^ error: using `_` for array lengths is unstable
Comment on lines +16 to +17
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt wipes nested parenthesis in expressions so in order to make sure people dont accidentally format away part of the test..

//[nogate]~| error: using `_` for array lengths is unstable
let b: [u8; 2] = b;

// This is the same case as AST types as the parser doesn't distinguish between const
// and type args when they share syntax
let c: Foo<_> = Foo::<1>;
//[nogate]~^ error: const arguments cannot yet be inferred with `_`
let c: Foo<(_)> = Foo::<1>;
//[nogate]~^ error: const arguments cannot yet be inferred with `_`
let c: Foo<(((_)))> = Foo::<1>;
//[nogate]~^ error: const arguments cannot yet be inferred with `_`
}
Loading