Construct OutputType using macro and print [=FILENAME] help info #140077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
clubby789
reviewed
Apr 20, 2025
clubby789
reviewed
Apr 20, 2025
clubby789
reviewed
Apr 20, 2025
jieyouxu
requested changes
Apr 21, 2025
rustbot
added
S-waiting-on-author
Signed-off-by: xizheyin <[email protected]>
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Apr 21, 2025
|
@rustbot author (for discussion) |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
|
@bors r+ rollup |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Apr 21, 2025
Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? `@jieyouxu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2025
Rollup of 12 pull requests Successful merges: - rust-lang#134213 (Stabilize `naked_functions`) - rust-lang#139795 (Clarify why SGX code specifies linkage/symbol names for certain statics) - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140036 (Advent of `tests/ui` (misc cleanups and improvements) [4/N]) - rust-lang#140047 (remove a couple clones) - rust-lang#140052 (Fix error when an intra doc link is trying to resolve an empty associated item) - rust-lang#140074 (rustdoc-json: Improve test for auto-trait impls) - rust-lang#140076 (jsondocck: Require command is at start of line) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140091 (build_helper: try to rename dir before delete) - rust-lang#140107 (rustc-dev-guide subtree update) r? `@ghost` `@rustbot` modify labels: rollup
ChrisDenton
added a commit
to ChrisDenton/rust
that referenced
this pull request
Apr 21, 2025
Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? ``@jieyouxu``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2025
…enton Rollup of 4 pull requests Successful merges: - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140128 (Use correct annotation for CSS pseudo elements) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
…enton Rollup of 5 pull requests Successful merges: - rust-lang#139981 (Don't compute name of associated item if it's an RPITIT) - rust-lang#140077 (Construct OutputType using macro and print [=FILENAME] help info) - rust-lang#140081 (Update `libc` to 0.2.172) - rust-lang#140094 (Improve diagnostics for pointer arithmetic += and -= (fixes rust-lang#137391)) - rust-lang#140128 (Use correct annotation for CSS pseudo elements) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
Rollup merge of rust-lang#140077 - xizheyin:issue-139805, r=jieyouxu Construct OutputType using macro and print [=FILENAME] help info Closes rust-lang#139805 Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages. On top of that, I optimized for `emit` help messages. r? ```@jieyouxu```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139805
Use define_output_types to define variants of OutputType, as well as refactor all of its methods for clarity. This way no variant is missed when pattern matching or output help messages.
On top of that, I optimized for
emithelp messages.r? @jieyouxu