-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove a test that never runs #140155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove a test that never runs #140155
Conversation
The coretests crate doesn't have the debug_typeid feature, so this test will always be configured out.
rustbot has assigned @Mark-Simulacrum. Use |
This was added by @kpreid in #136148. @Mark-Simulacrum had some feelings about I don't see much value in just removing the test if we're keeping all the other gated stuff in, though? I assume we should just fix the feature gating of coretest? |
To give some context, I probably originally wrote PR #136148 before the coretests split (#135937) was merged, so the test would have been in I don't have any particular opinion on what should happen to this test, other than: won't we eventually want coretests to be able to test features of core, even if this one test is not highly valuable? |
I tend to agree that removing the test seems like the wrong approach to fixing this (we should want the test somewhere...). I don't have a strong opinion on how we try to test this functionality though. |
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
The coretests crate doesn't have the debug_typeid feature, so this test will always be configured out.