Minor std style and doc tweaks #14019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me |
Prioritize `transmute` and `forget`.
from L, G to T, U. I don't know what L and G mean. T, U easier to understand.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
Substitute VSCode variables more generally
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
…ons (rust-lang#14019) This PR fixes an issue with the `significant_drop_in_scrutinee`, where the lint generates invalid Rust syntax when suggesting fixes for match expressions that are part of larger expressions, such as in assignment contexts. For example: ```rust let mutex = Mutex::new(State {}); let _ = match mutex.lock().unwrap().foo() { true => 0, false => 1, }; ``` would suggest: ```rust let _ = let value = mutex.lock().unwrap().foo(); match value { ``` With this PR, it now suggests: ```rust let value = mutex.lock().unwrap().foo(); let _ = match value { ``` closes: rust-lang#13986 changelog: [`significant_drop_in_scrutinee`] Fix incorrect suggestion for `significant_drop_in_scrutinee` lint in expression context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small bits of polish.