Remove Ident::empty
#140252
Open
Remove Ident::empty
#140252
+123
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
nnethercote
force-pushed
the
rm-Ident-empty
branch
from
ccb01ef to
3e46e7b
Compare
|
Helps with #137978. |
nnethercote
force-pushed
the
rm-Ident-empty
branch
from
3e46e7b to
889e4c6
Compare
|
fmease is on vacation. Please choose another assignee. |
|
Some changes occurred in compiler/rustc_attr_parsing |
|
Oh, the first commit here is from #140095 and doesn't need to be reviewed; this PR shouldn't be merged until that one has been. |
oli-obk
approved these changes
Apr 28, 2025
|
r=me when the other PR landed @bors reviewed |
oli-obk
added
S-waiting-on-author
nnethercote
force-pushed
the
rm-Ident-empty
branch
from
889e4c6 to
e7efeff
Compare
|
☔ The latest upstream changes (presumably #140388) made this pull request unmergeable. Please resolve the merge conflicts. |
As part of this, streamline a bunch of related stuff:
- Introduce `PathParser::word_sym`, as an alternative to
`PathParser::word`.
- Remove `MetaItemParser::path`, and just get the two parsers
one at a time.
- Rename `MetaItemParser::path_without_args` as `MetaItemParser::path`,
and avoid the clone.
- Inline and remove `MetaItemParser::word_without_args`, which has a
single use.
- Remove `MetaItemParser::word_or_empty_without_args`, which has a
single use.
- Remove `MetaItemParser::path_is`, which is unused.
- Remove `MetaItemListParser::all_{word,path}_list`, which are unused.
All uses have been removed. And it's nonsensical: an identifier by definition has at least one char. The commits adds an is-non-empty assertion to `Ident::new` to enforce this, and converts some `Ident` constructions to use `Ident::new`. Adding the assertion requires making `Ident::new` and `Ident::with_dummy_span` non-const, which is no great loss. The commit amends a couple of places that do path splitting to ensure no empty identifiers are created.
nnethercote
force-pushed
the
rm-Ident-empty
branch
from
e7efeff to
40952d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses have been removed. And it's nonsensical: an identifier by definition has at least one char.
r? @oli-obk