-
Notifications
You must be signed in to change notification settings - Fork 13.3k
bypass linker configuration and cross target check on x check
#140357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: onur-ozkan <[email protected]>
r? @clubby789 rustbot has assigned @clubby789. Use |
Signed-off-by: onur-ozkan <[email protected]>
Rerolling due to inactivity. r? bootstrap |
🥲 Sorry, I typed out an r=me when green but guess I forgot to hit comment @bors r+ rollup |
bypass linker configuration and cross target check on `x check` I was going to handle this using the untracked env approach, but I realized it somehow doesn't regress rust-lang#130108 anymore... Anyway, if it works, it works. 😄 No need to dig deeper but my guess is we moved some cache-invalidating env from these functions to others. Fixes rust-lang#133840
Rollup of 3 pull requests Successful merges: - rust-lang#140357 (bypass linker configuration and cross target check on `x check`) - rust-lang#140580 (Don't name variables from external macros in borrow errors.) - rust-lang#140630 (Async drop source info fix for proxy-drop-coroutine) r? `@ghost` `@rustbot` modify labels: rollup
Failed in rollup on
@bors r- |
This:
and other instances may need to be changed to |
I was going to handle this using the untracked env approach, but I realized it somehow doesn't regress #130108 anymore...
Anyway, if it works, it works. 😄 No need to dig deeper but my guess is we moved some cache-invalidating env from these functions to others.
Fixes #133840