Skip to content

bypass linker configuration and cross target check on x check #140357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onur-ozkan
Copy link
Member

I was going to handle this using the untracked env approach, but I realized it somehow doesn't regress #130108 anymore...

Anyway, if it works, it works. 😄 No need to dig deeper but my guess is we moved some cache-invalidating env from these functions to others.

Fixes #133840

@rustbot
Copy link
Collaborator

rustbot commented Apr 27, 2025

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 27, 2025
Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
Copy link
Member Author

Rerolling due to inactivity. r? bootstrap

@rustbot rustbot assigned albertlarsan68 and unassigned clubby789 May 4, 2025
@clubby789
Copy link
Contributor

🥲 Sorry, I typed out an r=me when green but guess I forgot to hit comment

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 4, 2025

📌 Commit 7669d50 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request May 4, 2025
bypass linker configuration and cross target check on `x check`

I was going to handle this using the untracked env approach, but I realized it somehow doesn't regress rust-lang#130108 anymore...

Anyway, if it works, it works. 😄 No need to dig deeper but my guess is we moved some cache-invalidating env from these functions to others.

Fixes rust-lang#133840
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2025
Rollup of 3 pull requests

Successful merges:

 - rust-lang#140357 (bypass linker configuration and cross target check on `x check`)
 - rust-lang#140580 (Don't name variables from external macros in borrow errors.)
 - rust-lang#140630 (Async drop source info fix for proxy-drop-coroutine)

r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxu
Copy link
Member

jieyouxu commented May 4, 2025

Failed in rollup on aarch64-apple:

2025-05-04T14:02:40.9144850Z failures:
2025-05-04T14:02:40.9145110Z 
2025-05-04T14:02:40.9145350Z ---- utils::cc_detect::tests::test_find stdout ----
2025-05-04T14:02:40.9145610Z 
2025-05-04T14:02:40.9145950Z thread 'utils::cc_detect::tests::test_find' panicked at src/bootstrap/src/utils/cc_detect/tests.rs:272:9:
2025-05-04T14:02:40.9146440Z CC not set for target x86_64-unknown-linux-gnu
2025-05-04T14:02:40.9146660Z 
2025-05-04T14:02:40.9146660Z 
2025-05-04T14:02:40.9146790Z failures:
2025-05-04T14:02:40.9147090Z     utils::cc_detect::tests::test_find

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 4, 2025
@clubby789
Copy link
Contributor

This:

let mut build = Build::new(Config { ..Config::parse(Flags::parse(&["check".to_owned()])) });

and other instances may need to be changed to "build" now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./x check std --target aarch64-apple-ios fails when cross-checking due to missing xcrun
6 participants