Correct attribute grammar in reference manual #14043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #13825. |
bors
added a commit
that referenced
this pull request
May 9, 2014
Attribute grammar in reference manual allowed `#[foo, bar]`, which does not match parser behavior. Also rename nonterminals to match parser code. Fix #13825.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
…hanged, r=Veykril fix: consider relative offset to fake ident token in expansion for completion Fixes rust-lang#13836 When we check if the offset of fake ident token is out of bounds in the "actual expansion" (i.e. expansion without the fake ident token), we should take relative offset to it into account to match [how we'd get token after expansion](https://github.com/rust-lang/rust-analyzer/blob/f1b257f4eb4fef74b42fd7135d1cf3884e8b51c9/crates/ide-completion/src/context/analysis.rs#L53-L54).
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
I ran across this message while writing code and thought it was quite odd. I've simplified it and hopefully made it clearer for non-native English speakers. changelog: clarify message for non-obvious precedence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute grammar in reference manual allowed
#[foo, bar], which does not match parser behavior.Also rename nonterminals to match parser code.
Fix #13825.