Miri subtree update

[RalfJung]

r? @ghost

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

[RalfJung]

@bors r+ p=1

[bors]

📌 Commit 929117e has been approved by RalfJung

It is now in the queue for this repository.

[bors]

⌛ Testing commit 929117e with merge efcbb94...

[bors]

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing efcbb94 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c83e55 (parent) -> efcbb94 (this PR)

Test differences

Show 33078 test diffs

Stage 1

• cmp::test_ordering_order: pass -> [missing] (J0)
• collections::btree::map::tests::test_range_inclusive_max_value: pass -> [missing] (J0)
• collections::vec_deque::tests::issue_108453: pass -> [missing] (J0)
• iter::adapters::zip::test_double_ended_zip: pass -> [missing] (J0)
• iter::traits::accum::test_iterator_sum_result: pass -> [missing] (J0)
• iter::traits::iterator::test_iterator_advance_back_by: pass -> [missing] (J0)
• mpmc::oneshot_single_thread_try_send_closed: pass -> [missing] (J0)
• mpsc::oneshot_single_thread_try_recv_closed: pass -> [missing] (J0)
• num::dec2flt::decimal_seq::test_parse: pass -> [missing] (J0)
• num::flt2dec::strategy::dragon::test_to_shortest_str: pass -> [missing] (J0)
• num::i128::test_signed_checked_div: pass -> [missing] (J0)
• num::i8::test_unbounded_shl: pass -> [missing] (J0)
• num::int_log::ilog10_of_0_panic: pass -> [missing] (J0)
• num::test_try_u16i16: pass -> [missing] (J0)
• num::test_try_u8i128: pass -> [missing] (J0)
• rc::panic_no_leak: pass -> [missing] (J0)
• slice::slice_index::rangeinclusive_len_len::index_mut_fail: pass -> [missing] (J0)
• slice::slice_index::rangetoinclusive_overflow::index_mut_fail: pass -> [missing] (J0)
• slice::test_rchunks_exact_last: pass -> [missing] (J0)
• slice::test_rchunks_exact_mut_zip_aliasing: pass -> [missing] (J0)
• slice::test_rotate_left: pass -> [missing] (J0)
• sync::test_live: pass -> [missing] (J0)
• sync::test_strong_count: pass -> [missing] (J0)
• test_append: pass -> [missing] (J0)
• vec::test_dedup_by_key: pass -> [missing] (J0)
• vec::test_into_iter_clone: pass -> [missing] (J0)
• vec_deque::test_index_out_of_bounds: pass -> [missing] (J0)
• errors::verify_const_eval_unstable_intrinsic_12: pass -> [missing] (J1)
• errors::verify_interface_ignoring_out_dir_15: pass -> [missing] (J1)
• errors::verify_passes_no_link_61: pass -> [missing] (J1)
• errors::verify_passes_repr_conflicting_75: pass -> [missing] (J1)
• markdown::parse::tests::test_without_breaks: pass -> [missing] (J1)
• parser::tests::non_overlapping: pass -> [missing] (J1)
• session_diagnostics::verify_borrowck_tail_expr_drop_order_8: pass -> [missing] (J1)
• spec::tests::aarch64_unknown_hermit: pass -> [missing] (J1)
• spec::tests::i686_unknown_hurd_gnu: pass -> [missing] (J1)
• spec::tests::loongarch64_unknown_none_softfloat: pass -> [missing] (J1)
• spec::tests::x86_64_unknown_uefi: pass -> [missing] (J1)
• symbols::tests::check_dup_keywords: pass -> [missing] (J1)
• fs::tests::recursive_rmdir_of_symlink: pass -> [missing] (J2)
• process::tests::signal_reported_right: pass -> [missing] (J2)
• slice::reverse_u128: pass -> [missing] (J2)
• slice::rotate_medium_by727_strings: pass -> [missing] (J2)
• sort::tests::stable::correct_u64_random_d20: pass -> [missing] (J2)
• str::starts_with_unichar::short_pile_of_poo: pass -> [missing] (J2)
• term::terminfo::searcher::tests::test_get_dbpath_for_term: ignore (buildbots don't have ncurses installed and I can't mock everything I need) -> [missing] (J2)
• vec::bench_clone_from_10_0000_1000: pass -> [missing] (J2)
• vec::bench_next_chunk: pass -> [missing] (J2)
• sort::tests::stable::observable_is_less_descending: ignore -> [missing] (J3)

Stage 2

• arc::slice: [missing] -> pass (J0)
• atomic::uint_max: [missing] -> pass (J0)
• f128::test_is_sign_negative: [missing] -> pass (J0)
• f64::test_acosh: [missing] -> pass (J0)
• instant_elapsed: [missing] -> pass (J0)
• iter::adapters::flatten::test_flatten_non_fused_outer: [missing] -> pass (J0)
• iter::traits::iterator::test_min_by_key: [missing] -> pass (J0)
• mem::align_of_basic: [missing] -> pass (J0)
• nonzero::test_nonzero_from_int_on_success: [missing] -> pass (J0)
• num::dec2flt::whitespace: [missing] -> pass (J0)
• num::flt2dec::estimator::test_estimate_scaling_factor: [missing] -> pass (J0)
• num::test_try_u64u64: [missing] -> pass (J0)
• rc::test_clone_from_slice_panic: [missing] -> pass (J0)
• rc::test_live: [missing] -> pass (J0)
• slice::slice_index::rangetoinclusive_overflow::index_fail: [missing] -> pass (J0)
• slice::test_chunks_iterator_0: [missing] -> pass (J0)
• slice::test_slice_from: [missing] -> pass (J0)
• tests::self_referential: [missing] -> pass (J0)
• time::debug_formatting_millis: [missing] -> pass (J0)
• vec::test_slice_to_mut: [missing] -> pass (J0)
• vec_deque::test_as_slices: [missing] -> pass (J0)
• doctest::tests::make_test_basic: [missing] -> pass (J1)
• edit_distance::tests::test_edit_distance: [missing] -> pass (J1)
• errors::verify_codegen_ssa_invalid_monomorphization_simd_shuffle_106: [missing] -> pass (J1)
• errors::verify_const_eval_unmarked_const_item_exposed_13: [missing] -> pass (J1)
• errors::verify_expand_module_file_not_found_31: [missing] -> pass (J1)
• errors::verify_incremental_hard_link_failed_25: [missing] -> pass (J1)
• errors::verify_mir_build_borrow_of_moved_value_15: [missing] -> pass (J1)
• errors::verify_passes_layout_abi_115: [missing] -> pass (J1)
• errors::verify_session_soft_float_ignored_50: [missing] -> pass (J1)
• lints::verify_lint_overflowing_uint_84: [missing] -> pass (J1)
• lints::verify_lint_unit_bindings_100: [missing] -> pass (J1)
• opaque::tests::test_cell: [missing] -> pass (J1)
• spec::tests::x86_64_unknown_illumos: [missing] -> pass (J1)
• tests::format_align_fill: [missing] -> pass (J1)
• util::comments::tests::test_block_doc_comment_3: [missing] -> pass (J1)
• vec::tests::range_iterator_iterates_backwards: [missing] -> pass (J1)
• btree::map::first_and_last_100_nightly: [missing] -> pass (J2)
• btree::set::clone_10k_and_pop_all: [missing] -> pass (J2)
• btree::set::difference_random_10k_vs_10k: [missing] -> pass (J2)
• iter::bench_range_step_by_fold_usize: [missing] -> pass (J2)
• net::udp::tests::socket_peer: [missing] -> pass (J2)
• slice::reverse_u16: [missing] -> pass (J2)
• slice::sort_unstable_large_big: [missing] -> pass (J2)
• sort::tests::stable::stability_cell_i32_saw_mixed: [missing] -> pass (J2)
• sort::tests::unstable::correct_i32_random_z1_03: [missing] -> pass (J2)
• str::bench_contains_32b_in_long: [missing] -> pass (J2)
• str::contains_bang_char::short_mixed: [missing] -> pass (J2)
• vec::bench_dedup_none_100: [missing] -> pass (J2)
• vec_deque::bench_into_iter_next_chunk: [missing] -> pass (J2)
• sort::tests::stable::stability_string_random_d20: [missing] -> ignore (J3)

(and 16450 additional test diffs)

Additionally, 16528 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
• J1: aarch64-apple, x86_64-apple-1
• J2: aarch64-apple, test-various, x86_64-apple-1
• J3: x86_64-gnu-aux

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard efcbb94dccbe0fcc1076f031f88332db4a6a2a52 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 5126.2s -> 1367.1s (-73.3%)
2. test-various: 4164.4s -> 2281.1s (-45.2%)
3. x86_64-apple-1: 8246.4s -> 5584.3s (-32.3%)
4. dist-aarch64-linux: 7761.7s -> 5452.5s (-29.8%)
5. x86_64-gnu-aux: 5992.3s -> 4249.3s (-29.1%)
6. aarch64-apple: 4072.3s -> 3316.4s (-18.6%)
7. dist-aarch64-apple: 5129.1s -> 4752.2s (-7.3%)
8. x86_64-gnu-nopt: 5791.5s -> 5459.9s (-5.7%)
9. dist-x86_64-apple: 9565.5s -> 9044.8s (-5.4%)
10. dist-apple-various: 5997.5s -> 6316.3s (5.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (efcbb94): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Max RSS (memory usage)

Results (primary 0.2%, secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.5%, 0.6%]	2
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.4%, 0.6%]	3

Cycles

Results (primary 2.9%, secondary -5.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-12.9%, -1.7%]	20
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 763.658s -> 763.233s (-0.06%)
Artifact size: 365.42 MiB -> 365.38 MiB (-0.01%)

[RalfJung]

This PR didn't change rustc, so I think that significance factor of 15x is way off -- seems like that benchmark got more noisy recently or so?

@rustbot label: +perf-regression-triaged

[Kobzol]

Yeah, this is actually a newly added benchmark (we're currently in the process of updating all primary benchmarks), which doesn't have a lot of history yet, so it's expected that it could be a bit noisy.

[RalfJung]

If the result display could communicate this somehow, that would be great. :)

[Kobzol]

It's kind of visible in the history graph if you know that the pink color means "missing data" xD I guess that we could also detect this when creating the comment and point it out somehow, although this situation only occurs very rarely (once every three years when we do a mass benchmark update or when the collector breaks somehow and misses data).

[Mark-Simulacrum]

This benchmark seems to have ~3% bimodality, dropping the regression label.