Skip to content

Fix test simd/extract-insert-dyn on s390x #140456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fneddy
Copy link
Contributor

@fneddy fneddy commented Apr 29, 2025

Fix the test for s390x by enabling s390x vector extension via target_feature(enable = "vector")(#127506). As this is is still gated by #![feature(s390x_target_feature)] we need that attribute also.

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2025
@wesleywiser
Copy link
Member

r? wesleywiser

Fix the test for s390x by enabling s390x vector extension via
`target_feature(enable = "vector")`(rust-lang#127506). As this is is still
gated by `#![feature(s390x_target_feature)]` we need that attribute
also.
@fneddy fneddy force-pushed the fix_s390x_codegen_simd_ext_ins_dyn branch from d00b33a to 24af1d9 Compare April 29, 2025 18:32
@wesleywiser
Copy link
Member

Thanks @fneddy!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit 24af1d9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants