Skip to content

Rollup of 5 pull requests #140836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented May 9, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

xizheyin and others added 11 commits May 8, 2025 21:17
Use span before macro expansion in lint for-loops-over-falibles

Fixes rust-lang#140747

I think there are going to be a lot of cases where macros are expanded in the compiler resulting in span offsets, and I'd like to know how that's typically handled. Does it have to be handled specially every time?
add signed ints to unn- transmutes to ensure feature parity

i forgot a few cases rust-lang/rust-clippy#14703

adds

- char -> i32
-  i32 -> char
- float -> size ()
-  size -> float
-   i32 -> float
`@rustbot` label L-unnecessary_transmutes
Fix `tests/rustdoc-json` triagebot message path

r? ``@aDotInTheVoid``
bootstrap: more consistent use of `...` when citing configuration snippets
Enable non-leaf Frame Pointers for Arm64 Windows

Microsoft recommends enabling frame pointers for Arm64 Windows as it enables fast stack walking, from <https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#integer-registers>:

> The frame pointer (x29) is required for compatibility with fast stack walking used by ETW and other services. It must point to the previous {x29, x30} pair on the stack.

I'm setting this to "non-leaf" as leaf functions shouldn't be spilling registers and so won't touch the frame pointer.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 9, 2025
@jhpratt
Copy link
Member Author

jhpratt commented May 9, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented May 9, 2025

📌 Commit c7b3875 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025
@bors
Copy link
Collaborator

bors commented May 9, 2025

⌛ Testing commit c7b3875 with merge f815d0d...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang#140801 (Use span before macro expansion in lint for-loops-over-falibles)
 - rust-lang#140804 (add signed ints to unn- transmutes to ensure feature parity)
 - rust-lang#140812 (Fix `tests/rustdoc-json` triagebot message path)
 - rust-lang#140817 (bootstrap: more consistent use of `...` when citing configuration snippets)
 - rust-lang#140828 (Enable non-leaf Frame Pointers for Arm64 Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented May 9, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2025
@jhpratt jhpratt closed this May 9, 2025
@jhpratt jhpratt deleted the rollup-1ciqork branch May 9, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants