Skip to content

Warn when #[export_name] is used with generic functions #140851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

Warn when #[export_name] is used with generic functions #140851

merged 1 commit into from
May 11, 2025

Conversation

mu001999
Copy link
Contributor

@mu001999 mu001999 commented May 9, 2025

Fixes #140742

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label May 9, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mu001999 mu001999 changed the title Add lint detects using #[export_name] on generic functions Warn when #[export_name] is used with generic functions May 10, 2025
bjorn3
bjorn3 reviewed May 10, 2025
View reviewed changes
@bjorn3
Copy link
Member

bjorn3 commented May 10, 2025

r? @bjorn3

@bors r+ rollup=maybe

@bors
Copy link
Collaborator

bors commented May 10, 2025

📌 Commit 0de994a has been approved by bjorn3

It is now in the queue for this repository.

@rustbot rustbot assigned bjorn3 and unassigned SparrowLii May 10, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
@bors
Auto merge of rust-lang#140915 - matthiaskrgr:rollup-lxce4zr, r=matth…
3528a5b 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#140397 (Add T-compiler backports Zulip notifications)
 - rust-lang#140851 (Warn when `#[export_name]` is used with generic functions)
 - rust-lang#140862 (Enable non-leaf Frame Pointers for Arm64EC Windows)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f55d0d into rust-lang:master May 11, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2025
@rust-timer
Unrolled build for rust-lang#140851
ae4bdb2 
Rollup merge of rust-lang#140851 - mu001999-contrib:new-lint, r=bjorn3

Warn when `#[export_name]` is used with generic functions

Fixes rust-lang#140742
@bors
Copy link
Collaborator

bors commented May 11, 2025

⌛ Testing commit 0de994a with merge 3528a5b...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@bjorn3 bjorn3

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

Warn when #[export_name] is used with generic functions
7 participants
@mu001999 @rustbot @rust-log-analyzer @bjorn3 @bors @jieyouxu @SparrowLii