-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ui/async-drop-initial: factor in panic strategy in destructor size check #140941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/async-drop-initial: factor in panic strategy in destructor size check #140941
Conversation
the size of `AsyncStruct`'s destructor depends on whether the configured panic strategy is 'unwind' or 'abort' so factor that into the test using conditional compilation fixes rust-lang#140939
r? @petrochenkov |
…-test, r=petrochenkov ui/async-drop-initial: factor in panic strategy in destructor size check the size of `AsyncStruct`'s destructor depends on whether the configured panic strategy is 'unwind' or 'abort' so factor that into the test using conditional compilation fixes rust-lang#140939 fixes rust-lang#140493
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bc7512e (parent) -> 420ca71 (this PR) Test differencesShow 33150 test diffsStage 1
Stage 2
(and 16504 additional test diffs) Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 420ca7104f4db107837cba4d8e48a82c53fcb76c --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (420ca71): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 773.173s -> 771.187s (-0.26%) |
the size of
AsyncStruct
's destructor depends on whether the configured panic strategy is 'unwind' or 'abort' so factor that into the test using conditional compilationfixes #140939
fixes #140493