Skip to content

Subtree update GCC backend 2025 05 14 #141002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
May 17, 2025

Conversation

GuillaumeGomez
Copy link
Member

cc @antoyo

bjorn3 and others added 30 commits April 14, 2025 09:38
…mentions

Enable `[no-mentions]` and `[issue-links]` in `rustbot`
Support for `f16` and `f128` is varied across targets, backends, and
backend versions. Eventually we would like to reach a point where all
backends support these approximately equally, but until then we have to
work around some of these nuances of support being observable.

Introduce the `cfg_target_has_reliable_f16_f128` internal feature, which
provides the following new configuration gates:

* `cfg(target_has_reliable_f16)`
* `cfg(target_has_reliable_f16_math)`
* `cfg(target_has_reliable_f128)`
* `cfg(target_has_reliable_f128_math)`

`reliable_f16` and `reliable_f128` indicate that basic arithmetic for
the type works correctly. The `_math` versions indicate that anything
relying on `libm` works correctly, since sometimes this hits a separate
class of codegen bugs.

These options match configuration set by the build script at [1]. The
logic for LLVM support is duplicated as-is from the same script. There
are a few possible updates that will come as a follow up.

The config introduced here is not planned to ever become stable, it is
only intended to replace the build scripts for `std` tests and
`compiler-builtins` that don't have any way to configure based on the
codegen backend.

MCP: rust-lang/compiler-team#866
Closes: rust-lang/compiler-team#866

[1]: https://github.com/rust-lang/rust/blob/555e1d0386f024a8359645c3217f4b3eae9be042/library/std/build.rs#L84-L186
…esleywiser

Share the naked asm impl between cg_ssa and cg_clif

This was introduced in rust-lang#128004.
…conv-attributes

Support more calling convention attributes
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 14, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 14, 2025

📌 Commit 1c4ab86 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2025
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 14, 2025
@nnethercote nnethercote removed their assignment May 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 14, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 14, 2025

📌 Commit d5c5a82 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 14, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 14, 2025
@bors
Copy link
Collaborator

bors commented May 17, 2025

⌛ Testing commit d5c5a82 with merge a69bc17...

@bors
Copy link
Collaborator

bors commented May 17, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing a69bc17 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2025
@bors bors merged commit a69bc17 into rust-lang:master May 17, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 17, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c8bda74 (parent) -> a69bc17 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a69bc17fb8026bdc0d24bb1896ff95f0eba1da4e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 7468.2s -> 8769.6s (17.4%)
  2. x86_64-apple-2: 4726.0s -> 5192.9s (9.9%)
  3. dist-apple-various: 6766.4s -> 7238.6s (7.0%)
  4. dist-riscv64-linux: 4959.3s -> 5259.3s (6.1%)
  5. dist-x86_64-apple: 8957.8s -> 8418.5s (-6.0%)
  6. dist-powerpc-linux: 5562.6s -> 5298.1s (-4.8%)
  7. x86_64-mingw-2: 6753.8s -> 7065.7s (4.6%)
  8. dist-loongarch64-musl: 5240.2s -> 5457.7s (4.2%)
  9. dist-loongarch64-linux: 6447.4s -> 6206.5s (-3.7%)
  10. dist-arm-linux: 4750.3s -> 4578.8s (-3.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@GuillaumeGomez GuillaumeGomez deleted the subtree-update_cg_gcc_2025-05-14 branch May 17, 2025 07:07
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a69bc17): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.4%, 0.6%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.1% [-1.1%, -1.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.6%, 1.1%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.3% [-2.0%, -0.8%] 7
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.939s -> 774.345s (0.18%)
Artifact size: 365.42 MiB -> 365.45 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.