-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustc-dev-guide subtree update #141025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
rustc-dev-guide subtree update #141025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2 commands do the same thing. Also, follow style used elsewhere in the guide.
Rustc pull update
Fix minor typo in serialization.md
Align advice to discourage issue-number-only names
Fix minor typo in installation.md
Fix minor typo in rustdoc-internals.md
add rdg push git config entry for git protocol pushers
This made it look the the topic was covered in the chapter just before the current one.
They are internal tools.
Discussed in PR 2378; the note was outdated.
remove dangling references
clean our crates
clean TypeFold* chapter
avoid duplicating commands
We changed this line and have not pushed it upstream yet, and upstream changed it in the meanwhile.
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
sorry for the noise... did this on the wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rustc-dev-guide
Area: rustc-dev-guide
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost