Skip to content

Update to LLVM 20.1.5 #141063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

Update to LLVM 20.1.5 #141063

merged 1 commit into from
May 18, 2025

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented May 16, 2025

@rustbot label A-LLVM T-compiler

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@cuviper
Copy link
Member

cuviper commented May 16, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 16, 2025

📌 Commit c7a2694 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025
@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Testing commit c7a2694 with merge ae3b909...

@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing ae3b909 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 18, 2025
@bors bors merged commit ae3b909 into rust-lang:master May 18, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ac17c34 (parent) -> ae3b909 (this PR)

Test differences

Show 9 test diffs

Stage 2

  • [assembly] tests/assembly/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [assembly] tests/assembly/sanitizer/kcfi/emit-arity-indicator.rs#x86_64: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [assembly] tests/assembly/x86_64-bigint-helpers.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/issues/issue-101082.rs#x86-64-v3: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [codegen] tests/codegen/sanitizer/kcfi/add-kcfi-arity-flag.rs#x86_64: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J1)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J1)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J2)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ae3b909a323aa771db8ee3919c1454b77db05fbf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2553.7s -> 3986.9s (56.1%)
  2. mingw-check: 1292.5s -> 1811.3s (40.1%)
  3. armhf-gnu: 4454.1s -> 6148.3s (38.0%)
  4. test-various: 4116.1s -> 5648.0s (37.2%)
  5. arm-android: 5319.6s -> 7107.3s (33.6%)
  6. x86_64-gnu-stable: 6521.3s -> 8702.2s (33.4%)
  7. x86_64-gnu: 6344.3s -> 8363.9s (31.8%)
  8. x86_64-apple-2: 6498.9s -> 4556.2s (-29.9%)
  9. x86_64-gnu-aux: 6011.4s -> 7796.2s (29.7%)
  10. x86_64-gnu-nopt: 5608.2s -> 7261.3s (29.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@dianqk dianqk deleted the llvm-20.1.5 branch May 18, 2025 08:43
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ae3b909): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.7%, 1.0%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)
1.2% [0.4%, 2.1%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-0.6%, -0.6%] 1
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.4%, 2.5%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-1.0%, -0.4%] 4
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 777.472s -> 777.393s (-0.01%)
Artifact size: 365.48 MiB -> 365.45 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants