Skip to content

Fix the issue of typo of comma in arm parsing #141077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

chenyukang
Copy link
Member

Fixes #140991

I also checked is it a '/', since it's near from ',' from keyboard.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2025
@wesleywiser
Copy link
Member

Thanks @chenyukang!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 30, 2025

📌 Commit 5f8954b has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request May 30, 2025
…, r=wesleywiser

Fix the issue of typo of comma in arm parsing

Fixes rust-lang#140991

I also checked is it a '/', since it's near from ',' from keyboard.
bors added a commit that referenced this pull request May 30, 2025
Rollup of 8 pull requests

Successful merges:

 - #140825 (Add Range parameter to `BTreeMap::extract_if` and `BTreeSet::extract_if`)
 - #141077 (Fix the issue of typo of comma in arm parsing)
 - #141237 (Implement ((un)checked_)exact_div methods for integers)
 - #141494 (mir-opt: Do not transform non-int type in match_branches)
 - #141609 (core: begin deduplicating pointer docs)
 - #141768 (ci: use arm to calculate job matrix)
 - #141771 (Increase timeout for new bors try builds)
 - #141781 (Fix spans for unsafe binders)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5e139db into rust-lang:master May 31, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
rust-timer added a commit that referenced this pull request May 31, 2025
Rollup merge of #141077 - chenyukang:yukang-fix-140991-comma, r=wesleywiser

Fix the issue of typo of comma in arm parsing

Fixes #140991

I also checked is it a '/', since it's near from ',' from keyboard.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 31, 2025
Rollup of 8 pull requests

Successful merges:

 - rust-lang/rust#140825 (Add Range parameter to `BTreeMap::extract_if` and `BTreeSet::extract_if`)
 - rust-lang/rust#141077 (Fix the issue of typo of comma in arm parsing)
 - rust-lang/rust#141237 (Implement ((un)checked_)exact_div methods for integers)
 - rust-lang/rust#141494 (mir-opt: Do not transform non-int type in match_branches)
 - rust-lang/rust#141609 (core: begin deduplicating pointer docs)
 - rust-lang/rust#141768 (ci: use arm to calculate job matrix)
 - rust-lang/rust#141771 (Increase timeout for new bors try builds)
 - rust-lang/rust#141781 (Fix spans for unsafe binders)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typoing "." instead of "," in a match produces confusing error messages
4 participants