mk: Bundle jemalloc with make dist #14116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dist tarball doesn't depend on git, so all git submodules must be included inside of it.
|
Landing with two somewhat related changes in #14119. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
Render discriminant inlay hints for mixed variants if at least one discriminant is specified
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 6, 2025
Turns out I was completely overcomplicating myself, there was no need for an external tool such as becnhv2 or even the original becnh, we already had the benchmarking infrastructure right under our noses! This PR implements a new **lintcheck** option called --perf, using it as a flag will mean that lintcheck builds Clippy as a release package and hooks perf to it. The realization that lintcheck is already 90% of what a benchmarking tool needs came to me in a dream ☁️ changelog:none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 3, 2025
In rust-lang#14116 we added a benchmarking option for Lintcheck, this commit adds a new chapter to the book AND improves that option into a more usable state. It's recommended to review one commit at a time. - **Document how to benchmark with lintcheck --perf** - **Several improvements on lintcheck perf (desc.)** - Now lintcheck perf deletes target directory after benchmarking, benchmarking with a cache isn't very useful or telling of any precise outcome. - Support for benchmarking several times without having to do a cargo clean. - Compress perf.data changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dist tarball doesn't depend on git, so all git submodules must be included
inside of it.