GetUserProfileDirectoryW is now documented to always store the size #141405
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-windows
|
The Miri subtree was changed cc @rust-lang/miri |
RalfJung
commented
May 22, 2025
| @@ -230,16 +230,16 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> { | |||
| interp_ok(match directories::UserDirs::new() { | |||
| Some(dirs) => { | |||
| let home = dirs.home_dir(); | |||
| let size_avail = if this.ptr_is_null(size.ptr())? { | |||
| let size_avail = if this.ptr_is_null(buf)? { | |||
There was a problem hiding this comment.
The comment already talked about checking buf, not size... and we unconditionally write size so it being null already triggered UB before.
There was a problem hiding this comment.
Makes sense to me - docs agree that lpcchSize is required:
https://learn.microsoft.com/en-us/windows/win32/api/userenv/nf-userenv-getuserprofiledirectoryw
_In_ HANDLE hToken,
_Out_writes_opt_(*lpcchSize) LPWSTR lpProfileDir,
_Inout_ LPDWORD lpcchSize
(There's no Opt suffix to denote that nullptr is an allowed value for lpcchSize)
Great work as always :)
|
Great, thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to match MicrosoftDocs/sdk-api#1810
Also fix a bug in the Miri implementation while I am starting at that code...
r? @ChrisDenton
Fixes #141254