Skip to content

remove f16: From<u16> #141893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

remove f16: From<u16> #141893

merged 1 commit into from
Jun 4, 2025

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Jun 2, 2025

it's not a lossless conversion

r? @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 2, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

Great catch, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 80e44de has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@tgross35 tgross35 added the F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` label Jun 2, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
remove `f16: From<u16>`

it's not a lossless conversation

r? `@tgross35`
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
remove `f16: From<u16>`

it's not a lossless conversation

r? ``@tgross35``
chenyukang added a commit to chenyukang/rust that referenced this pull request Jun 4, 2025
remove `f16: From<u16>`

it's not a lossless conversation

r? ```@tgross35```
bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 6 pull requests

Successful merges:

 - #141250 (add s390x z17 target features)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141959 (Add more missing 2015 edition directives)
 - #141960 (Use non-2015 edition paths in tests that do not test for their resolution)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 4, 2025
remove `f16: From<u16>`

it's not a lossless conversion

r? `@tgross35`
bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 9 pull requests

Successful merges:

 - #141271 (Streamline some attr parsing APIs)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141857 (coretests: move float tests from num to floats module and use a more flexible macro to generate them)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141939 (exact_div: add tests)
 - #141959 (Add more missing 2015 edition directives)
 - #142002 (redesign stage 0 std follow-ups part2)
 - #142007 (Improve some `Visitor` comments.)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 4, 2025
Rollup of 7 pull requests

Successful merges:

 - #141271 (Streamline some attr parsing APIs)
 - #141570 (Fix incorrect eq_unspanned in TokenStream)
 - #141893 (remove `f16: From<u16>`)
 - #141924 (Lightly tweak docs for BTree{Map,Set}::extract_if)
 - #141939 (exact_div: add tests)
 - #141959 (Add more missing 2015 edition directives)
 - #142007 (Improve some `Visitor` comments.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 005490c into rust-lang:master Jun 4, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 4, 2025
rust-timer added a commit that referenced this pull request Jun 4, 2025
Rollup merge of #141893 - usamoi:lossless, r=tgross35

remove `f16: From<u16>`

it's not a lossless conversion

r? ``@tgross35``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants