-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Turn stdarch
into a Josh subtree
#141899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Turn stdarch
into a Josh subtree
#141899
Conversation
This is to combat the spurious CI failures in emulated run. Also helps with updatability and compatibility - it will work even if Intel changes the link
Since [1], this will come automatically from `rustc-std-workspace-core` and the crates.io dependency should no longer be specified. [1]: rust-lang#141993
Synchronizes the lists of detectable features with macOS 15.5 “Sequoia” as of June 9, 2025.
@bors2 try |
Turn `stdarch` into a Josh subtree In a similar vein as #141229, this PR makes the `stdarch` repository a Josh subtree (it was previously a submodule). The initial commit of `stdarch` upon this is based is `b6e2249e388f520627544812649b77b0944e1a2e`, which is the previous commit SHA of the `stdarch` submodule. The sync was performed according to https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg. This was decided in rust-lang/stdarch#1655. Test pull PR on my fork: Kobzol/stdarch#1 Test push PR on my fork: Kobzol#59 I plan to use the same Rust (miri-inspired) tooling that we use for `rustc-dev-guide` to enable pulls/pushes on stdarch. Note that this repository currently doesn't have any stdarch-specific tests, so before that, the subtree should only be modified through this repository only when dealing with changes that contain "cyclical dependencies" between stdarch and rustc. The long term vision is to integrate stdarch into rust-lang/rust completely. CC `@Amanieu` try-job: aarch64-apple try-job: aarch64-gnu try-job: `x86_64-msvc-*` try-job: x86_64-gnu try-job: x86_64-gnu-aux
💔 Test failed
|
This comment has been minimized.
This comment has been minimized.
This will need a stdarch bump with the avx512 features removed. |
☔ The latest upstream changes (presumably #142443) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased the PR on top of latest |
|
@bors2 try |
Turn `stdarch` into a Josh subtree In a similar vein as #141229, this PR makes the `stdarch` repository a Josh subtree (it was previously a submodule). The initial commit of `stdarch` upon this is based is `1b4d15df12079504942d0a3f1030b2039b8a776c`, which is the previous commit SHA of the `stdarch` submodule. The sync was performed according to https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg. This was decided in rust-lang/stdarch#1655. Test pull PR on my fork: Kobzol/stdarch#1 Test push PR on my fork: Kobzol#59 I plan to use the same Rust (miri-inspired) tooling that we use for `rustc-dev-guide` to enable pulls/pushes on stdarch. Note that this repository currently doesn't have any stdarch-specific tests, so before that, the subtree should only be modified through this repository only when dealing with changes that contain "cyclical dependencies" between stdarch and rustc. The long term vision is to integrate stdarch into rust-lang/rust completely. CC `@Amanieu` try-job: aarch64-apple try-job: aarch64-gnu try-job: `x86_64-msvc-*` try-job: x86_64-gnu try-job: x86_64-gnu-aux
Did we have successful compiler-builtin syncs in both directions, to confirm that the basic approach works? |
I believe so (rust-lang/compiler-builtins#946, #142489). Not sure why it's so important though (what's the "basic approach"?). We're using josh in the same way here and for compiler-builtins as we have been using it for rustc-dev-guide, and that has been working for a couple of months already. The approach definitely works; we can always screw up when setting the initial PR for each subtree though :) |
Okay cool :)
With earlier josh-ifications sometimes there were issues with the initial import that only surfaced on a sync, so I became a bit paranoid here.
|
In a similar vein as #141229, this PR makes the
stdarch
repository a Josh subtree (it was previously a submodule). The initial commit ofstdarch
upon this is based is1b4d15df12079504942d0a3f1030b2039b8a776c
, which is the previous commit SHA of thestdarch
submodule. The sync was performed according to https://hackmd.io/7pOuxnkdQDaL1Y1FQr65xg.This was decided in rust-lang/stdarch#1655.
Test pull PR on my fork: Kobzol/stdarch#1
Test push PR on my fork: Kobzol#59
I plan to use the same Rust (miri-inspired) tooling that we use for
rustc-dev-guide
to enable pulls/pushes on stdarch.Note that this repository currently doesn't have any stdarch-specific tests, so before that, the subtree should only be modified through this repository only when dealing with changes that contain "cyclical dependencies" between stdarch and rustc. The long term vision is to integrate stdarch into rust-lang/rust completely.
CC @Amanieu
try-job: aarch64-apple
try-job: aarch64-gnu
try-job:
x86_64-msvc-*
try-job: x86_64-gnu
try-job: x86_64-gnu-aux