more dynamic allocation work #14322
Merged
more dynamic allocation work #14322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| } | ||
| ty::ty_str => { | ||
| with_cond(bcx, not_null, |bcx| { | ||
| let unit_ty = ty::sequence_element_type(bcx.tcx(), t); | ||
| let bcx = tvec::make_drop_glue_unboxed(bcx, llbox, unit_ty); | ||
| trans_exchange_free(bcx, llbox) | ||
| // FIXME: #13994: the old `Box<str>` will not support sized deallocation | ||
| trans_exchange_free(bcx, llbox, 0, 8) |
There was a problem hiding this comment.
And soon we'll be able to remove these entirely!
This is now only used internally by the compiler.
The support for sized deallocation is nearly complete. The only known missing pieces are `Box<str>`, `Box<[T]>` and `proc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.