std: minor simplification to sync::deque. #14378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ptr::copy_nonoverlapping_memory(buf.elem(t) as *mut T, | ||
| self.elem(t), | ||
| (b - t) as uint); | ||
|
|
There was a problem hiding this comment.
I think for this one I may prefer to keep the loop. I'm hoping to keep this code as close as possible to the original code in the chase-lev paper to make it easy to see the parallels.
That being said, if you've seen some good performance wins from this change, a comment saying what the psudocode is would probably be sufficient.
|
You have quite the eagle eye for an improvement like this! Thanks! |
|
Updated, it's even more pointless now! \o/ (I actually found this experimenting with a tool for finding potentially-invalid |
bors
added a commit
that referenced
this pull request
May 24, 2014
Might as well remove the duplication/`forget` call.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2023
internal: Bump chalk This release fixes a problem around GATs (rust-lang/chalk#790). While a regression test is added in chalk's own test suite, I also added one in ours so that we can catch regressions when we move away from chalk. Fixes rust-lang#14164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might as well remove the duplication/
forgetcall.