Make most lexer errors non-fatal #14388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| c: char) | ||
| -> ! { | ||
| let mut m = m; | ||
| fn fatal_span_char<S: StrAllocating>(rdr: &mut StringReader, |
There was a problem hiding this comment.
The StrAllocating trait is mostly just an implementation detail, and it's kinda sad to see it used here for this (maybe not a pattern we want to promote). Can this take &str for the same level of convenience?
There was a problem hiding this comment.
It could. I started with StrAllocating because I hadn't vetted every callsite to see if any allocated. It turns out none do. I'll go ahead and make the change.
There was a problem hiding this comment.
FWIW, my other thought was taking IntoMaybeOwned, but that would just end up being a proxy for StrAllocating because it would end up being let mut m = m.into_maybe_owned().into_strbuf().
Most errors that arise in the lexer can be recovered from. This allows for more than one syntax error to be reported at a time.
|
Updated with @alexcrichton suggestion. |
|
mmmm I love me some non-fatal errors |
bors
added a commit
that referenced
this pull request
May 24, 2014
…chton Most errors that arise in the lexer can be recovered from. This allows for more than one syntax error to be reported at a time.
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Mar 20, 2025
Follow-up of rust-lang/rust-clippy#11421. I can't yet make the annotations mandatory because there is an issue with `tests/ui-internal/custom_ice_message.rs`: the error message is not emitted as JSON, meaning that we can't match it with `ui_test`. I need to check if it's a bug in rustc or if `ui_test` needs to handle this case somehow. changelog: Add missing tests annotations for `ui-internal` r? @flip1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most errors that arise in the lexer can be recovered from. This allows
for more than one syntax error to be reported at a time.