Skip to content

Rename UTF16Item[s] to Utf16Item[s] #14437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2014
Merged

Conversation

Sawyer47
Copy link
Contributor

According to Rust's style guide acronyms should be CamelCase.

@Sawyer47
Copy link
Contributor Author

There is also OSRng and FPCategory, but I didn't want to change them without asking.

@lilyball
Copy link
Contributor

Given the ubiquity of "UTF" it looks weird to me to see "Utf".

@Sawyer47
Copy link
Contributor Author

I agree, but on the other hand "everything should be CamelCase" rule makes sense. "Uuid" or "Html" looks equally weird to me.

@kud1ing
Copy link

kud1ing commented May 26, 2014

The style guide currently states Acronyms should be camel case, too: Uuid, not UUID.
https://github.com/mozilla/rust/wiki/Note-style-guide

@alexcrichton
Copy link
Member

I'm in favor of this because it is following our existing conventions, just bringing some old code up to date. This will break previous users of these items, so can you flag this change as a breaking change as described here?

According to Rust's style guide acronyms should be CamelCase.

[breaking-change]
@Sawyer47
Copy link
Contributor Author

Commit message changed. What about other names that don't follow this rule? Should I create an issue to collect all other type names that may need renaming?

@alexcrichton
Copy link
Member

Either an issue or a PR is ok, incremental changes are perfectly ok as well!

bors added a commit that referenced this pull request May 28, 2014
According to Rust's style guide acronyms should be CamelCase.
@bors bors closed this May 28, 2014
@bors bors merged commit 8c5a8e1 into rust-lang:master May 28, 2014
@Sawyer47 Sawyer47 deleted the utf16-items branch May 31, 2014 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants