librustc: Implement overloading for the call operator behind a feature #14590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| callee.span, | ||
| format!("unxpected callee type {}", | ||
| callee_ty.repr(self.tcx())).as_slice()); | ||
| match self.tcx() |
There was a problem hiding this comment.
Could you add a comment here saying what we're looking for? It is not obvious from the code.
|
LGTM - r+ with the nits addressed and a few more tests |
gate. This is part of unboxed closures.
bors
added a commit
that referenced
this pull request
Jun 10, 2014
gate. This is part of unboxed closures. r? @nick29581
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
`triagebot.toml` is related to the repo behavior wrt interactions, and must be kept inline with what is done in the CI. changelog: none r? @flip1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gate.
This is part of unboxed closures.
r? @nick29581