rustdoc: Fix some more assorted broken links #14592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the type associated with the impl is `pub use`'d or referenced twice in a downstream crate, the impl will attempt to be inlined twice. Closes rust-lang#14584
|
Pushed a fix for #14594 as well |
| use option::Option; | ||
|
|
||
| #[doc(hidden)] |
There was a problem hiding this comment.
Why are these hidden but Alignment etc not hidden?
There was a problem hiding this comment.
Alignment is publicly available in the Formatter struct, but all these other bits are just internals of the fmt bytecode essentially. They all need to be public to be constructed anywhere.
Inlining caused implementors to show up multiple times. cc rust-lang#14584
Apparently relying on provided_source in ty::Method is unreliable! Closes rust-lang#14594
The logical location for the documentation of a primitive is in the module that declared it was a module for that primitive.
|
Added a commit to put primitives in the right place in the documentation r? |
bors
added a commit
that referenced
this pull request
Jun 5, 2014
These are a few assorted fixes for some issues I found this morning (details in the commits).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few assorted fixes for some issues I found this morning (details in the commits).