Derive Hash for Bitv and BitvSet #14749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -672,7 +672,7 @@ impl<'a> RandomAccessIterator<bool> for Bits<'a> { | |||
| /// It should also be noted that the amount of storage necessary for holding a | |||
| /// set of objects is proportional to the maximum of the objects when viewed | |||
| /// as a `uint`. | |||
| #[deriving(Clone)] | |||
| #[deriving(Clone, Hash)] | |||
There was a problem hiding this comment.
I don't think this is correct, since it is hashing the underlying storage as well as the semantic value. I think this will mean let x = BitvSet::new(); x.insert(1000); x.remove(1000); hashes differently to just BitvSet::new() even though they are semantically identical (see the implementation of PartialEq).
|
@huonw updated. The impl for BitvSet is slower than it could be because I'm not sure there's any guarantee that the BigBitv is as small as possible at all times. |
bors
added a commit
that referenced
this pull request
Jun 8, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…=lnicola feat: define problem matcher for panics in VS Code Now in VS Code "go to next error" (`F8`) will bring you to the source of a panic.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 15, 2025
…lang#14749) changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14744