Add a RefCell-free way to make cycles in Rc and Arc #14928
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently tell people to use
Weak
to break cycles, but only provide two ways to do so, both unsavory:unsafe
andRefCell
. Additionally, there is nothing built into either of those mechanisms that prevents creating anRc
cycle. This PR fixes that.Incidentally, I haven't seen any convincing uses for reference counted cycles, so I have no idea if this is the ideal API. However, it is definitely better than what is currently in place.