librustc: Remove outdated reference to ~ syntax
#15071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The error message now looks like: Is it better to use |
|
You should use |
|
Should |
|
@schmee @steveklabnik updated with your feedback, thanks! |
| @@ -1121,7 +1121,10 @@ impl<'t,TYPER:Typer> MemCategorizationContext<'t,TYPER> { | |||
| "captured outer variable".to_string() | |||
| } | |||
| _ => { | |||
| format!("dereference of `{}`-pointer", ptr_sigil(pk)) | |||
| match pk { | |||
| OwnedPtr => format!("dereference of `{}`", ptr_sigil(pk)), | |||
There was a problem hiding this comment.
Should this match also single out a GcPtr? Also, can you add tests for both these cases?
|
Pushed again with tests + a new message for |
bors
added a commit
that referenced
this pull request
Jun 24, 2014
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
internal: remove spurious regex dependency - replace tokio's env-filter with a smaller&simpler targets filter - reshuffle logging infra a bit to make sure there's only a single place where we read environmental variables - use anyhow::Result in rust-analyzer binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15052