Rename recvfrom -> recv_from, sendto -> send_to. #15265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I agree with this. If we do it, then yes we should leave the old ones, marked deprecated and explaining why. |
|
|
POSIX has recvfrom(2) and sendto(2), but their name seem not to be suitable with Rust. We already renamed getpeername(2) and getsockname(2), so I think it makes sense. Alternatively, `receive_from` would be fine. However, we have `.recv()` so I chose `recv_from`. Signed-off-by: OGINO Masanori <[email protected]>
We leave them for compatibility, but mark them as deprecated. Signed-off-by: OGINO Masanori <[email protected]>
bors
added a commit
that referenced
this pull request
Jul 2, 2014
POSIX has recvfrom(2) and sendto(2), but their name seem not to be suitable with Rust. We already renamed getpeername(2) and getsockname(2), so I think it makes sense. Alternatively, `receive_from` would be fine. However, we have `.recv()` so I chose `recv_from`. What do you think? If this makes sense, should I provide `recvfrom` and `sendto` deprecated methods just calling new methods for compatibility?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
…r=lnicola
editor/code: Update dependencies
This includes:
- Some major changes.
- [typescript-eslint v6](https://typescript-eslint.io/blog/announcing-typescript-eslint-v6/)
- [prettier v3](https://prettier.io/blog/2023/07/05/3.0.0.html)
- ~Update ``@types/vscode`` to [1.79](https://code.visualstudio.com/updates/v1_79).~
- ~[1.80 has been released](https://code.visualstudio.com/updates/v1_80). We can now bump it.~
- _Update1: I removed this change. See the below comments_
- and some patch/minor updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX has recvfrom(2) and sendto(2), but their name seem not to be suitable with Rust. We already renamed getpeername(2) and getsockname(2), so I think it makes sense.
Alternatively,
receive_fromwould be fine. However, we have.recv()so I choserecv_from.What do you think? If this makes sense, should I provide
recvfromandsendtodeprecated methods just calling new methods for compatibility?