Rational that reduce to ints should print like ints #15329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| num.and_then(|n:T| den.clone().and_then(|d: T| { | ||
| Some(Ratio::new(n.clone(), d)) | ||
| })) |
There was a problem hiding this comment.
You should be able to avoid the clone calls here by using explicit pattern matching rather than helper methods:
match (num, den) {
(Some(n), Some(d)) => Some(Ratio::new(n, d)),
_ => None
}There was a problem hiding this comment.
tried it and you're right. Plus it looks much more readable too... Thanks!
|
Looks good to me, thanks! Could you squash these commits together? |
|
@alexcrichton sorry, I messed up the rebasing. I'll push a fresh commit referencing this one. |
bors
added a commit
that referenced
this pull request
Jul 3, 2014
Tried squashing commits for #15329, failed spectacularly. This is a fresh PR for the same change. @alexcrichton?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you print rational expressions it currently looks bad to see integers formatted as fractions with a denominator of 1 (even though that's how they are stored internally).
For instance, in http://is.gd/0gRT1T,