rustc: Forbid plugin_registrar in only rlib form #15565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -473,6 +473,13 @@ impl<'a> PluginMetadataReader<'a> { | |||
| let registrar = decoder::get_plugin_registrar_fn(library.metadata.as_slice()).map(|id| { | |||
| decoder::get_symbol(library.metadata.as_slice(), id) | |||
| }); | |||
| if library.dylib.is_none() && registrar.is_some() { | |||
| let message = format!("crate `{}` found in rlib format but must \ | |||
There was a problem hiding this comment.
(Or maybe even "plugin crate {} only found in ...".)
|
r=me with a tweaked error message. |
|
|
||
| #![feature(phase)] | ||
| #[phase(plugin)] extern crate rlib_crate_test; | ||
| //~^ ERROR: crate `rlib_crate_test` found in rlib format but must be available in the dylib format |
There was a problem hiding this comment.
This probably needs adjusting for the new message...
There was a problem hiding this comment.
I'm always sure to remind myself when I read comments about tweaking messages to go update the tests, and then I also always manage to forget by the time I git push...
If a plugin registrar is available, the library must be found in dylib form, not just in rlib form. Closes rust-lang#15475
bors
added a commit
that referenced
this pull request
Jul 11, 2014
If a plugin registrar is available, the library must be found in dylib form, not just in rlib form. Closes #15475
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2023
Implement `write_via_move` intrinsic for mir-eval Required for getting `write!`ing to work again. we fail with an odd type mimsatch eval error after this change though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a plugin registrar is available, the library must be found in dylib form, not
just in rlib form.
Closes #15475