Skip to content

Assorted small fixes #15584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2014
Merged

Assorted small fixes #15584

merged 4 commits into from
Jul 13, 2014

Conversation

alexcrichton
Copy link
Member

  • Don't warn about #[crate_name] if --crate-name is specified
  • Don't warn about non camel case identifiers on #[repr(C)] structs
  • Switch mode to mode_t in libc.

It's just an annoying error if you use --crate-name on the command line and you
also have a #[crate_name] specified
C structs predominately do not use camel case identifiers, and we have a clear
indicator for what's a C struct now, so excuse all of them from this stylistic
lint.
While I'm at it, export O_SYNC with the other flags that are exported.

Closes rust-lang#15582
bors added a commit that referenced this pull request Jul 13, 2014
* Don't warn about `#[crate_name]` if `--crate-name` is specified
* Don't warn about non camel case identifiers on `#[repr(C)]` structs
* Switch `mode` to `mode_t` in libc.
@bors bors closed this Jul 13, 2014
@bors bors merged commit 2dfbe7f into rust-lang:master Jul 13, 2014
@alexcrichton alexcrichton deleted the warn-annoyances branch July 13, 2014 17:32
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 18, 2023
…r, r=Veykril

Diagnose private fields in record constructor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants