Document PriorityQueue. #15856
Document PriorityQueue. #15856
Conversation
| /// A priority queue implemented with a binary heap | ||
| /// A priority queue implemented with a binary heap. | ||
| /// | ||
| /// This will be max-heap. |
There was a problem hiding this comment.
"This will be a max-heap."
|
Thanks so much for all of this, this is great. :) One small stylistic note: you can use |
|
+1 on |
|
I do like |
|
Made a change at |
| pub fn new() -> PriorityQueue<T> { PriorityQueue{data: vec!(),} } | ||
|
|
||
| /// Create an empty PriorityQueue with a specific capacity. | ||
| /// This pre-allocates memory so we don't have to allocate |
There was a problem hiding this comment.
"This preallocates enough memory for capacity elements, so that the PriorityQueue does not have to be reallocated until it contains at least that many values."
There was a problem hiding this comment.
Thanks, this is much better.
|
Needs rebase. |
|
r=me with that rebase (and possibly squashing the last 4 commits into a single one). |
|
Rebased and squashed. |
minor: Make "Expand macro" command title more explicit Closes [rust-lang#15856](rust-lang/rust-analyzer#15856). I opted for "caret", since it's the better term (cursor is the mouse), but I'm not sure how popular it is these days.
Add examples to methods.