rustc: Future proof runtime injection #15987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename and gensym the runtime on import, so that users can't refer to the `native` crate. This is unlikely to break code, but users should import the "native" crate directly. [breaking-change]
|
Oh yes please! Could you add a test for this as well? |
|
@alexcrichton Done. |
| // This is testing that users can't access the runtime crate. | ||
|
|
||
| // The rt has been called both 'native' and 'rt' | ||
| use native; //~ ERROR unresolved import |
There was a problem hiding this comment.
FWIW, a use of a crate at the top level like this fails already: http://is.gd/MfQbdO (swapping the comments there allows it to compile.)
bors
added a commit
that referenced
this pull request
Jul 26, 2014
Rename and gensym the runtime on import, so that users can't refer to the `native` crate. This is unlikely to break code, but users should import the "native" crate directly. [breaking-change] cc @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename and gensym the runtime on import, so that users
can't refer to the
nativecrate.This is unlikely to break code, but users should import the "native" crate directly.
[breaking-change]
cc @alexcrichton