Preparing for running lexer tests on bots #15988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll use this to run a subset of the test suite onto a dedicated bot. This puts the grammar tests and the pretty-printer tests under check-secondary. It leanves the pretty tests under plain `check` for now, until the new bot is added to take over. Because check-secondary is not run as part of `make check` there will be a set of tests that most users never run and are only checked by bors. I think this will be ok because grammar tests should rarely regress, and the people regressing such tests should have the fortitude to deal with it.
Invoke rustc in a way that sets LD_LIBRARY_PATH, and disable the deps on RustLexer.class when antlr isn't available.
This appears to be redundantly named with a shortcut target for testing the syntax crate.
bors
added a commit
that referenced
this pull request
Jul 26, 2014
Add `check-secondary`, which runs the pretty and lexer tests so we can run them on a dedicated bot. Leaves the pretty tests running under `check` until the bots are switched over. Also fixes some issues. r? @cmr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
check-secondary, which runs the pretty and lexer tests so we can run them on a dedicated bot. Leaves the pretty tests running undercheckuntil the bots are switched over. Also fixes some issues.r? @cmr