Skip to content

Add a split_at method to slice::ImmutableVector #16188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nham
Copy link
Contributor

@nham nham commented Aug 2, 2014

This operation seems common enough that it would be convenient for it to be a standard method.

This method is similar to the mut_split_at method of slice::MutableVector.
@alexcrichton
Copy link
Member

This is a trait in the prelude and is hence quite important and should be modified carefully.

That being said, we provide mut_split_at, so it makes sense to me that we would provide split_at as well. I'd like to get some other opinions on this, however.

@brson
Copy link
Contributor

brson commented Aug 4, 2014

I agree it makes sense to have both. Note that this will shortly become split_at_mut when @aturon lands his conventions cleanup.

bors added a commit that referenced this pull request Aug 5, 2014
This operation seems common enough that it would be convenient for it to be a standard method.
@bors bors closed this Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants