Move system header includes above valgrind.h include #16323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rust_builtins.c is the only file that includes the valgrind.h. Can we put this workaround there to avoid modifying the upstream valgrind code? |
|
(With a comment about why) |
This allows rustc to be build under msys2's mingw64 gcc
c-nixon
changed the title
|
Updated to a reordering of the include statements in rust-builtin.c instead of changing valgrind.h |
bors
added a commit
that referenced
this pull request
Aug 9, 2014
This allows rustc to be built with msys2's mingw64 Fixes #16347.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rustc to be built with msys2's mingw64
Fixes #16347.