Rolling up PRs in the queue #16895
Merged
Rolling up PRs in the queue #16895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lovely command has already been introduced, so let's take advantage of it.
Others in this list are Capitalized, so do it here too.
The implemented fix rounds half-way cases away from zero as described in the original comments. This rounding algorithm is sometimes called arithmetic rounding. It is described further here: http://en.wikipedia.org/wiki/Rounding#Round_half_away_from_zero I also added several new tests to prevent regressions.
Also use //! Instead of /*! in liblog.
Also made some opinionated changes such as to prefer license over licence and judgment over judgement.
wrong de- word.
Addresses this comment: rust-lang#16721 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
Resolve whether `$pat` is `$pat_param` or not via 🌟hygiene🌟 Before we just picked the edition from the macro def which is wrong, since a macro call can produce the fragment kind from a different definition site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this again!