Skip to content

libnative/io/file_unix: remove superfluous retry(). #16964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2014

Conversation

@lilyball
Copy link
Contributor

lilyball commented Sep 3, 2014

I think it's probably a good idea to remove retry() around calls that can't return EINTR. At the very least, it avoids confusion when the reader sees retry() and believes that means the call can in fact return EINTR. @alexcrichton?

@alexcrichton
Copy link
Member

I'm a little wary with this in that are we 100% certain that every single implementation of these syscalls will never return EINTR? I certainly agree that according to the documentation in the linked manpages none of these can return EINTR, however!

Regardless, it's pretty easy to add these all back at a later date, so I'm ok removing them for now because in theory any compliant implementation won't return EINTR.

@lilyball
Copy link
Contributor

lilyball commented Sep 4, 2014

@alexcrichton I was wary too, but I checked a random sampling of the functions in the manpages for both OS X and Linux, and every function I looked at matched the specification. I would assume a non-compliant implementation would cause errors in lots of programs, so I think it's safe to assume that won't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants