Fix deprecate warning "extern crate ... as ..." #17015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4780,7 +4780,7 @@ impl<'a> Parser<'a> { | |||
| self.span_warn(span, | |||
| format!("this extern crate syntax is deprecated. \ | |||
| Use: extern create \"{}\" as {};", | |||
There was a problem hiding this comment.
While you're at it, might want to fix the misspelling of "crate" as "create" here.
|
The typo fix was noticed independently #17032, could you remove that commit? E.g. (BTW, github doesn't provide notifications if a PR is updated, so please comment when you do.) |
seb-m
force-pushed
the
fix-extern-crate-as
branch
from
379e39b to
d40fb4c
Compare
|
Ah sorry Huon! I didn't know that. I've reverted the typo fix. |
|
Looks like you there's a merge conflict - could you rebase this on top of |
Its arguments were inverted.
seb-m
force-pushed
the
fix-extern-crate-as
branch
from
d40fb4c to
8baff54
Compare
|
I think I did what you told me (modulo I didn't mess up something with git) and resolved the merge conflict, so it might be fine now. |
bors
added a commit
that referenced
this pull request
Sep 7, 2014
Its arguments were inverted. For instance it displayed this message: ``` warning: this extern crate syntax is deprecated. Use: extern create "foobar" as foo; ``` Instead of: ``` warning: this extern crate syntax is deprecated. Use: extern create "foo" as foobar; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its arguments were inverted.
For instance it displayed this message:
Instead of: