Skip to content

don't say compromise #17019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2014
Merged

don't say compromise #17019

merged 1 commit into from
Sep 7, 2014

Conversation

steveklabnik
Copy link
Member

@dherman doesn't like it 😄

@dherman doesn't like it 😄
bors added a commit that referenced this pull request Sep 7, 2014
@bors bors closed this Sep 7, 2014
@bors bors merged commit d929d83 into rust-lang:master Sep 7, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Previously PRs would only do a build on Windows, which confusingly
meant that PRs got a green tick for Windows despite not testing them.

See discussion in rust-lang#17019.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Run Windows tests on PRs too

Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them.

See discussion in rust-lang#17019.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
fix: VFS should not confuse paths with source roots that have the same prefix

Previously, the VFS would assign paths to the source root that had the longest string prefix match. This would break when we had source roots in subdirectories:

```
/foo
/foo/bar
```

Given a file `/foo/bar_baz.rs`, we would attribute it to the `/foo/bar` source root, which is wrong.

As a result, we would attribute paths to the wrong crate when a crate was in a subdirectory of another one. This is more common in larger monorepos, but could occur in any Rust project.

Fix this in the VFS, and add a test.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Previously PRs would only do a build on Windows, which confusingly
meant that PRs got a green tick for Windows despite not testing them.

See discussion in rust-lang#17019.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
Run Windows tests on PRs too

Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them.

See discussion in rust-lang#17019.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
fix: VFS should not confuse paths with source roots that have the same prefix

Previously, the VFS would assign paths to the source root that had the longest string prefix match. This would break when we had source roots in subdirectories:

```
/foo
/foo/bar
```

Given a file `/foo/bar_baz.rs`, we would attribute it to the `/foo/bar` source root, which is wrong.

As a result, we would attribute paths to the wrong crate when a crate was in a subdirectory of another one. This is more common in larger monorepos, but could occur in any Rust project.

Fix this in the VFS, and add a test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants