don't say compromise #17019
Merged
don't say compromise #17019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dherman doesn't like it 😄
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them. See discussion in rust-lang#17019.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Run Windows tests on PRs too Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them. See discussion in rust-lang#17019.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
fix: VFS should not confuse paths with source roots that have the same prefix Previously, the VFS would assign paths to the source root that had the longest string prefix match. This would break when we had source roots in subdirectories: ``` /foo /foo/bar ``` Given a file `/foo/bar_baz.rs`, we would attribute it to the `/foo/bar` source root, which is wrong. As a result, we would attribute paths to the wrong crate when a crate was in a subdirectory of another one. This is more common in larger monorepos, but could occur in any Rust project. Fix this in the VFS, and add a test.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them. See discussion in rust-lang#17019.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Run Windows tests on PRs too Previously PRs would only do a build on Windows, which confusingly meant that PRs got a green tick for Windows despite not testing them. See discussion in rust-lang#17019.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
fix: VFS should not confuse paths with source roots that have the same prefix Previously, the VFS would assign paths to the source root that had the longest string prefix match. This would break when we had source roots in subdirectories: ``` /foo /foo/bar ``` Given a file `/foo/bar_baz.rs`, we would attribute it to the `/foo/bar` source root, which is wrong. As a result, we would attribute paths to the wrong crate when a crate was in a subdirectory of another one. This is more common in larger monorepos, but could occur in any Rust project. Fix this in the VFS, and add a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dherman doesn't like it 😄