Skip to content

Rolling up PRs in the queue #17127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Sep 9, 2014
Merged

Rolling up PRs in the queue #17127

merged 43 commits into from
Sep 9, 2014

Conversation

alexcrichton
Copy link
Member

No description provided.

Robert Gawdzik ☢ and others added 21 commits September 5, 2014 14:59
 - Ensures the propagated negation sign is properly utilized during type
   checking.
 - Removed redundant type checking, specifically regarding the out of bounds checking
   on a bounded type.
 - Closes rust-lang#16684
This code used to produce an ICE on the definition of trait Bar
with the following message:

Type parameter out of range when substituting in region 'a (root
type=fn(Self) -> 'astr) (space=FnSpace, index=0)

Closes rust-lang#16218.
This test verifies that casting from the same lifetime on a value
to the same lifetime on a trait succeeds. Closes rust-lang#10766.
Breaks `iterate(f, seed)`, use `iterate(seed, f)` instead.
The convention is to have the closure last.

Closes rust-lang#17066.

[breaking-change]
Other languages may not want to have a leading #-line get stripped.
Win32/WinSock APIs never call WSASetLastError() with WSAEINTR
unless a programmer specifically cancels the ongoing blocking call by
a deprecated WinSock1 API WSACancelBlockingCall().
So the errno check was simply removed and retry() became an id function
on Windows.
Note: Windows' equivalent of SIGINT is always handled in a separate thread:
http://msdn.microsoft.com/en-us/library/windows/desktop/ms682541%28v=vs.85%29.aspx
"CTRL+C and CTRL+BREAK Signals"

Also, incidentally rename a type parameter and clean up some module imports.
This code used to produce the following ICE:

   error: internal compiler error: get_unique_type_id_of_type() -
   unexpected type: closure,
   ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
   ReScope(63u32))

This is a regression test for issue rust-lang#17021.
itself.

This breaks code like:

    for &x in my_vector.iter() {
        my_vector[2] = "wibble";
        ...
    }

Change this code to not invalidate iterators. For example:

    for i in range(0, my_vector.len()) {
        my_vector[2] = "wibble";
        ...
    }

The `for-loop-does-not-borrow-iterators` test for rust-lang#8372 was incorrect
and has been removed.

Closes rust-lang#16820.

[breaking-change]
This breaks code that uses the `..xs` form anywhere but at the end of a
slice. For example:

    match foo {
        [ 1, ..xs, 2 ]
        [ ..xs, 1, 2 ]
    }

Add the `#![feature(advanced_slice_patterns)]` gate to reenable the
syntax.

RFC rust-lang#54.

Closes rust-lang#16951.

[breaking-change]
There isn't a good way to fit this in, so let's just not
mention it.

Fixes rust-lang#16792.
instead of prefix `..`.

This breaks code that looked like:

    match foo {
        [ first, ..middle, last ] => { ... }
    }

Change this code to:

    match foo {
        [ first, middle.., last ] => { ... }
    }

RFC rust-lang#55.

Closes rust-lang#16967.

[breaking-change]
Resolves bounds for `type` and adds the warning for 'unbounds' (? bounds) that we have for bounds.

Closes rust-lang#16888
@pcwalton
Copy link
Contributor

pcwalton commented Sep 9, 2014

@bors: retry

@bors bors closed this Sep 9, 2014
@bors bors merged commit e5abe15 into rust-lang:master Sep 9, 2014
@alexcrichton alexcrichton deleted the rollup branch September 9, 2014 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.