doc: Removing repeated variable name to make it less ambiguious #17456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. |
|
I was trying to make it more clear by showing the parts and their combination, but yes, then you have to talk about shadowing. I think this is an improvement. Thanks! |
|
Hey Steve, Sorry, I'm new here... I see it passed 3.3, but is failing on LLVM_VERSION=3.4 normal? |
|
Yes. Travis is just a quick check, bors is the real CI. |
|
Ahh cool. Thanks :) |
bors
added a commit
that referenced
this pull request
Sep 23, 2014
While reading the intro, I was confused as to why there were two variables named "numbers". Unless I'm mistaken and it's not necessary, let's get rid of it to make it clearer.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 23, 2024
…ng, r=Veykril Remove panicbit.cargo extension warning A warning was introduced regarding the incompatabilities between `rust-analyzer` and `panicbit.cargo`'s diagnostics / `cargo check` functionality. This functionality has been removed in the latest version of the cargo extension (`0.3.0`), which is why the warning can be removed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the intro, I was confused as to why there were two variables named "numbers". Unless I'm mistaken and it's not necessary, let's get rid of it to make it clearer.