Replaced some TODO by FIXME #17479
Merged
Replaced some TODO by FIXME #17479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
| @@ -7281,7 +7281,7 @@ EOF | |||
| test "$compiler_needs_object" = yes && | |||
| test -z "$libobjs"; then | |||
| # extract the archives, so we have objects to list. | |||
| # TODO: could optimize this to just extract one archive. | |||
| # FIXME: could optimize this to just extract one archive. | |||
There was a problem hiding this comment.
This is actually vendored source code, so this shouldn't get modified.
|
Thanks! |
|
Could you squash the two commits together as well? Also feel free to comment on the PR whenever you update it! Sadly github doesn't send out notifications for pushes or force-pushes. |
gamazeps
force-pushed
the
issue17478
branch
from
5fe8b35 to
e543878
Compare
|
Done ;) |
bors
added a commit
that referenced
this pull request
Sep 30, 2014
bors
added a commit
that referenced
this pull request
Sep 30, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17478